Topics

PR with appVeyor build failing

Abdel
 

Hi Cyrille and all,

You wrote:

I still however do not understand why the build failed this way on the first commit (cf. e-mail from Abdel).


It doesn't come from your code but from the new code linting that you fixed in your third commit.

Regarding your other questions, it is the reviewers who do this work.

Congratulations, Mick approved your 3 commits and merged them into the master branch.

Your PR will certainly be integrated in nvda-2019.3.

Thanks for your great work.

Kind regards,
Abdel.


Le 16/09/2019 à 15:19, Cyrille via Groups.Io a écrit :

Hello all
Thanks for your various replies.
The issue was due to new code linting and I have fixed it in a third commit. AppVeyor check is now OK.
I still however do not understand why the build failed this way on the first commit (cf. e-mail from Abdel). In the second commit I have only modified translators comments, so nothing to do with 'comtypes.gen.FlashAccessibility' où^import issue.
Anyway since all seems fine now:
1. Should I ask for a reviewer? If yes, who?
2. Should I update with respect to master branch since new commits have been added to master meanwhile? If yes, is it allowed to rebase?
Thanks,
Regards,
Cyrille
----- Mail d'origine -----
De: Abdel <abdelkrim.bensaid@...>
À: nvda-devel@groups.io
Envoyé: Mon, 16 Sep 2019 12:18:01 +0200 (CEST)
Objet: Re: [nvda-devel] PR with appVeyor build failing

Hi Cyrille and all,


Derek is right, the detail of the error is present in the log.


Here is the log page and below, the detail from line 226 to 239:

https://ci.appveyor.com/project/NVAccess/nvda/builds/27387406
226

interfaceAction(["source\comInterfaces\FlashAccessibility.py",
"source\comInterfaces\__pycache__\FlashAccessibility.cpython-37.pyc"],
["source\typelibs\FlashAccessibility.tlb"])

227

scons: *** [source\comInterfaces\FlashAccessibility.py]
ModuleNotFoundError : No module named
'comtypes.gen.FlashAccessibility'

228

Traceback (most recent call last):

229

  File
"C:\projects\nvda\include\scons\src\engine\SCons\Action.py",
line 1202, in execute

230

    result = self.execfunction(target=target, source=rsources,
env=env)

231

  File "C:\projects\nvda\source\comInterfaces_sconscript", line
27, in interfaceAction

232

    comtypes.client.GetModule(source)

233

  File
"C:\projects\nvda\include\comtypes\comtypes\client\_generate.py",
line 146, in GetModule

234

    return _my_import("comtypes.gen." + modulename)

235

  File
"C:\projects\nvda\include\comtypes\comtypes\client\_generate.py",
line 24, in _my_import

236

    return __import__(fullname, globals(), locals(), ['DUMMY'])

237

ModuleNotFoundError: No module named
'comtypes.gen.FlashAccessibility'

238

scons: building terminated because of errors.

239

Command exited with code 2


Kind regards,

Abdel.

Le 16/09/2019 à 02:12, derek riemer a
écrit :
I believe there is a txt file in the appVeyor
artifacts with the exact failures.

On Sun, Sep 15, 2019 at 4:13
PM Luke Davis <luke@...> wrote:
I saw that. There was a link in
that email (which I no longer have), can you not

look at that to see the errors? I never tried looking through
one of those,

other than seeing that they go to appveyor's site.

Would the Appveyor console messages have it?


On Sun, 15 Sep 2019, Cyrille via Groups.Io wrote:

> I have pushed a new commit with only translator comments
modified. Now the build ends up with Flake8 error. How can I
analyze it?



--
Derek Riemer

Improving the world one byte at a time!        ⠠⠊⠍⠏⠗⠕⠧⠬ ⠮ ⠸⠺
⠐⠕ ⠃⠽⠞⠑ ⠁⠞ ⠁ ⠐⠞⠖

•    Accessibility enthusiast.

•    Proud user of the NVDA screen reader.

•    Open source enthusiast.

•    Skier.

•    Personal website: https://derekriemer.com