Hi Cyrille and all,
I still however do not understand why the
build failed this way on the first commit (cf. e-mail from
It doesn't come from your code but from the new code linting that
you fixed in your third commit.
Regarding your other questions, it is the reviewers who do this
Congratulations, Mick approved your 3 commits and merged them into
the master branch.
Your PR will certainly be integrated in nvda-2019.3.
Thanks for your great work.
Le 16/09/2019 à 15:19, Cyrille via Groups.Io a écrit :
Thanks for your various replies.
The issue was due to new code linting and I have fixed it in
a third commit. AppVeyor check is now OK.
I still however do not understand why the build failed this
way on the first commit (cf. e-mail from Abdel). In the second
commit I have only modified translators comments, so nothing to
do with 'comtypes.gen.FlashAccessibility' où^import issue.
Anyway since all seems fine now:
1. Should I ask for a reviewer? If yes, who?
2. Should I update with respect to master branch since new
commits have been added to master meanwhile? If yes, is it
allowed to rebase?
Hi Cyrille and all,
Derek is right, the detail of the error is present in the log.
Here is the log page and below, the detail from line 226 to 239:
scons: *** [source\comInterfaces\FlashAccessibility.py]
ModuleNotFoundError : No module named
Traceback (most recent call last):
line 1202, in execute
result = self.execfunction(target=target, source=rsources,
File "C:\projects\nvda\source\comInterfaces_sconscript", line
27, in interfaceAction
line 146, in GetModule
return _my_import("comtypes.gen." + modulename)
line 24, in _my_import
return __import__(fullname, globals(), locals(), ['DUMMY'])
ModuleNotFoundError: No module named
scons: building terminated because of errors.
Command exited with code 2
Le 16/09/2019 à 02:12, derek riemer a
I believe there is a txt file in the appVeyor
artifacts with the exact failures.
On Sun, Sep 15, 2019 at 4:13
PM Luke Davis <luke@...
I saw that. There was a link
that email (which I no longer have), can you not
look at that to see the errors? I never tried looking
one of those,
other than seeing that they go to appveyor's site.
Would the Appveyor console messages have it?
On Sun, 15 Sep 2019, Cyrille via Groups.Io wrote:
> I have pushed a new commit with only translator
modified. Now the build ends up with Flake8 error. How can I
Improving the world one byte at a time! ⠠⠊⠍⠏⠗⠕⠧⠬ ⠮ ⠸⠺
⠐⠕ ⠃⠽⠞⠑ ⠁⠞ ⠁ ⠐⠞⠖
• Accessibility enthusiast.
• Proud user of the NVDA screen reader.
• Open source enthusiast.
• Personal website: https://derekriemer.com