Re: Braille Extender add-on: much needed code cleanup, rewrites, proper Python 3 porting and optimizations in progress
toggle quoted messageShow quoted text
Perhaps. What can help with that effort is source code comments and separating patches into separate modules so that when it comes time to send pull requests to NVDA, just the needed parts can be picked and submitted. Another thing I’m going to do (provided that Andre agrees) is convert scripts into script decorators, along with letting the add-on take advantage of more modern NVDA changes.
From: firstname.lastname@example.org <email@example.com> On Behalf Of Leonard de Ruijter
Sent: Thursday, July 16, 2020 1:20 AM
Subject: Re: [nvda-devel] Braille Extender add-on: much needed code cleanup, rewrites, proper Python 3 porting and optimizations in progress
Though I don't have time too look into this myself, I really dig this idea and am looking forward for it to progress.
One thing that could also be taken into account while refactoring is monkey patching. If we have an overview of what functionality in the add-on requires monkeypatching currently, we can propose better ways in NVDA core to handle these cases, such as with extension points.
On 16/07/2020 09:50, Joseph Lee wrote: