Re: Add-on Updater 19.08 released, first of two mandatory updates for everyone #addonrelease

 

Hi,
Let's see...
Currently, when one looks at add-on files repo and opens up the PHP file
responsible for hosting add-on download keys, you'll notice that add-ons
with stable releases does not have a qualifier after the short add-on name
key. For example, for Toolbars Explorer, the key is tbx, and the stable
version is just labeled "tbx" without any qualifier. This is the key
characteristic that allows Add-on Updater to decide which key to look up,
along with being guided by manifests from add-ons.
The above came about because until last year there was no update channel
defined in manifests for vast majority of add-ons; the first two add-ons
that had channel set were ones that had update check facility built in:
StationPlaylist and Windows 10 App Essentials. Also, in the early days of
community add-ons website, we only had two channels: stable and development,
with the only difference being the qualifier at the end of the add-on
download key (a key with "-dev" indicated a development channel, whereas
just the key meant stable). To account for these, Add-on Updater, which can
be traced to StationPlaylist's update check facility with some things coming
from Windows 10 App Essentials, is programmed to view "None" (nothing) as
stable release, with added bits from Add-on Template's build vars module
based on ones from StationPlaylist.
Part of the reason why update check is failing for some add-ons with
"stable" string set as update channel is precisely because of the ambiguity
mentioned, which will be corrected in the add-on template this weekend with
help from people.
As for viewing None as same as stable (and telling authors to leave the
update channel as "None" for stable releases), that can change depending on
how the server counterpart to Add-on Updater (put on hold due to Python 3
work) is programmed. As of now, Add-on Updater performs the role of a
"client" and a "server": client as far as fetching update info is concerned,
and checking the manifest for channels and parsing version info is the job
of the server component.
Cheers,
Joseph

-----Original Message-----
From: nvda-devel@groups.io <nvda-devel@groups.io> On Behalf Of Luke Davis
Sent: Saturday, August 10, 2019 12:10 PM
To: nvda-devel@groups.io
Subject: Re: [nvda-devel] Add-on Updater 19.08 released, first of two
mandatory updates for everyone #AddonRelease

I wrote:

That does not make clear in the least, that stable and None are the
same
That was supposed to say:
That does not make clear in the least, that stable and None aren't the same

Luke

On Sat, 10 Aug 2019, Luke Davis wrote:

On Sat, 10 Aug 2019, Joseph Lee wrote:

This means the author may have (and did) provide wrong update channel
identification for stable releases (it should be None, but some
add-ons did say "stable").
Could that possibly be because of the following ambiguous statement in
the addonTemplate buildVars.py?:

# Add-on update channel (default is stable or None)
"addon_updateChannel" : None,

That does not make clear in the least, that stable and None are the
same thing.
It could mean that there are two defaults (depending on what, who knows).
Or it could mean that stable (actually "stable") and None are equivalent.
Or it could mean that there are three options: stable, None, and the
implied development/dev, whatever the proper string is for that,
without explaining what the None channel is or will do.
Personally I took it to mean the third option, and so released in the
"stable" channel.

Can we do this with constants?

STABLE = None
DEV = "development" # or whatever it's supposed to be

Then alter the section in buildVars to say something like:

# Add-on update channel. Set to one of the constants: STABLE or DEV
"addon_updateChannel" : STABLE,

Luke

On Sat, 10 Aug 2019, Joseph Lee wrote:

Hi,
This means the author may have (and did) provide wrong update channel
identification for stable releases (it should be None, but some
add-ons did say "stable"). I'm going to add a workaround for this
issue in 19.08.1 and
19.09 and no more after that.
Cheers,
Joseph

-----Original Message-----
From: nvda-devel@groups.io <nvda-devel@groups.io> On Behalf Of
Brian's Mail list account via Groups.Io
Sent: Saturday, August 10, 2019 5:36 AM
To: nvda-devel@groups.io
Subject: Re: [nvda-devel] Add-on Updater 19.08 released, first of two
mandatory updates for everyone #AddonRelease

Hi this add on when in Alpha and I launch alpha after closing the
stable version of nvda has this worning sound.

DEBUG - core.main (13:30:51.371):
Initializing core pump
DEBUG - core.main (13:30:51.371):
Initializing watchdog
DEBUG - core.main (13:30:51.372):
initializing updateCheck
INFO - core.main (13:30:51.375):
NVDA initialized
DEBUG - core.main (13:30:51.375):
entering wx application main loop
IO - speech.speak (13:30:51.408):
Speaking [LangChangeCommand ('en_GB'), 'Taskbar'] DEBUGWARNING -
characterProcessing._getSpeechSymbolsForLocale
(13:30:51.408):
No CLDR data for locale en_GB
ERROR - stderr (13:30:52.446):
Exception in thread Thread-24:
Traceback (most recent call last):
File "threading.pyc", line 926, in _bootstrap_inner File
"threading.pyc", line 870, in run File "C:\nvda
extra\userConfig\addons\addonUpdater\globalPlugins\addonUpdater\addon
Handler
Ex.py",
line 134, in fetchAddonInfo
addonUrl = results[addonKey]
KeyError: 'tbx-stable'
IO - inputCore.InputManager.executeGesture (13:30:58.320):
Input: kb(desktop):control+alt+r
IO - speech.speak (13:30:58.414):
Speaking [LangChangeCommand ('en_GB'), 'reboot nvda with log
terminal'] IO
- speech.speak (13:30:58.417):
Speaking [LangChangeCommand ('en_GB'), '80 space', 'blank'] INFO -
core.main
(13:30:58.505):
Exiting


No idea what it means though.
Brian


bglists@...
Sent via blueyonder.
Please address personal E-mail to:-
briang1@..., putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <@joslee>
To: <nvda-devel@groups.io>
Sent: Wednesday, August 07, 2019 4:43 PM
Subject: [nvda-devel] Add-on Updater 19.08 released, first of two
mandatory updates for everyone #AddonRelease


Hi everyone,



Add-on Updater 19.08 is now available. This is the first of two
mandatory updates for anyone using Add-on Updater.



Specifically:



* Version 19.08 removes an experimental feature to present a toast
message on Windows 10 when new add-on updates become available.
Although this is useful, it was found that it isn't ready for
primetime yet (thanks for community feedback). Because this
experiment was controlled by a setting, version 19.08 removes this,
hence this being
a mandatory update.
* Version 19.08 includes a possible fix for download time-out.
Specifically, if you respond to update notification more than five
minutes of it appearing, you may get an error in regards to update
download. This has been corrected, along with a new way of accessing
the add-ons website to retrieve update status information for
various add-ons.



The following describes Add-on Updater releases for the next few weeks:



* 19.08 (released today): supports NVDA 2019.1, first mandatory
update.
* 19.08.1: to be released shortly after NVDA 2019.2 is released. The
only change will be minimum NVDA version supported - 2019.2. This is
not a mandatory update.
* 19.09 (anniversary update): to be released later in August (or by
early September at the latest), second mandatory update for everyone
and requiring NVDA 2019.2 or later. By then, if the time-out bug is
resolved, it'll become a permanent feature of this add-on.



Cheers,

Joseph













Join nvda-devel@groups.io to automatically receive all group messages.