Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #906 Regression: en+klatt4 voice produces different/random wave output
By valdisvi:

It looked like it was problem on my computer. Full reconfiguration and rebuild fixed this issue.


[espeak-ng:master] Issue #906 Regression: en+klatt4 voice produces different/random wave output closed by valdisvi.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By raminhalavati:

Thank you. I will follow up the issue with Talkback and look back.


[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By raminhalavati:

Thank you. I will follow up the issue with Talkback and loop back.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #907 Remove duplicated code from test scripts
By jaacoppi:

This is something I've also been thinking about but never tried to do. A great idea!


[espeak-ng:master] New Comment on Issue #798 MBROLA download page for Windows is not working
By hgneng:

Is https://api.256file.com/mbrolatools35.exe/m-download-138135.html working?

It works for me. I think new link should be updated in following document: https://github.com/espeak-ng/espeak-ng/blob/master/docs/mbrola.md#windows-installation


espeak-ng@groups.io Integration <espeak-ng@...>
 

11 New Commits:

[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
2954e498caef: Change shell to sh as it is more common

Modified: tests/bom.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
ec552d2566c5: Move common functions into common script

Added: tests/common
Modified: tests/cmd_options.test
Modified: tests/dictionary.test
Modified: tests/klatt.test
Modified: tests/language-numbers-cardinal.test
Modified: tests/language-numbers-ordinal.test
Modified: tests/language-phonemes.test
Modified: tests/language-pronunciation.test
Modified: tests/language-replace.test
Modified: tests/mbrola.test
Modified: tests/ssml.test
Modified: tests/translate.test
Modified: tests/variants.test
Modified: tests/voices.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
6fcb110b83fd: Move MESSAGE argument as 4th, to make arguments similar to other functions

Modified: tests/common
Modified: tests/language-numbers-cardinal.test
Modified: tests/language-numbers-ordinal.test
Modified: tests/language-pronunciation.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
e14b567d77ae: Merge MESSAGE and TEST_BROKEN arguments

Modified: tests/common


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
43dee60c33e1: Make test_dict the same as test_phonemes

Modified: tests/common
Modified: tests/dictionary.test
Modified: tests/voices.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
842cd3e25eeb: Replace test_phonemes(), test_phonemes1() and test_dict() with single test_phon()

Modified: tests/common
Modified: tests/dictionary.test
Modified: tests/language-numbers-cardinal.test
Modified: tests/language-numbers-ordinal.test
Modified: tests/language-pronunciation.test
Modified: tests/translate.test
Modified: tests/voices.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
df8dd607dfa4: Replace test_lang() and test_voice() with test_wav() and test_phwav() which uses test_wav()

Modified: tests/common
Modified: tests/klatt.test
Modified: tests/language-phonemes.test
Modified: tests/mbrola.test
Modified: tests/variants.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
4588258cd7a2: Make test_replace() similar to other functions

Modified: tests/common


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
5f6b5c8093ab: Make output more similar to the output before refactorization

Modified: tests/common
Modified: tests/mbrola.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
d15de8cd7838: Fix introduced bugs during refactorization

Modified: tests/dictionary.test
Modified: tests/language-pronunciation.test


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
899b26846819: Add OPTIONS argument to test_phon() and use it instead of test_commandlineoptions()

Modified: tests/cmd_options.test
Modified: tests/common


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#907 Remove duplicated code from test scripts

To be sure that I didn't introduce regressions, I checked that tests pass after each commit. Attached file shows difference between output before and after refactoring: output-diff.txt


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #908 Licensing question regarding linking
By valdisvi:

Simple explanation of GPL-v3 states: "Any modifications to or software including (via compiler) GPL-licensed code must also be made available under the GPL along with build & install instructions." If you don't want to open code of your application, technologically easiest and legally correct way is to use unmodified, stand-alone eSpeak NG through its CLI interface. Calling its API from separate thread/process can also be legally correct. Of course, any modifications/additions you may need in eSpeak NG should be made public. In best way — as improvements in original eSpeak NG project, but you may maintain your own fork if you think it is worth effort.


[espeak-ng:master] New Comment on Issue #908 Licensing question regarding linking
By valdisvi:

Simple explanation of GPL-v3 states: "Any modifications to or software including (via compiler) GPL-licensed code must also be made available under the GPL along with build & install instructions." If you don't want to open code of your application, technologically easiest and legally correct way is to use unmodified, stand-alone eSpeak NG through its CLI interface. Calling its unmodified API from separate thread/process can also be legally correct. Of course, any modifications/additions you may need in eSpeak NG should be made public. In best way — as improvements in original eSpeak NG project, but you may maintain your own fork if you think it is worth effort.