Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By valdisvi:

This looks like trolling, see also https://github.com/ruby/ruby/pull/4310


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#900 Revert "Fixed a typo in UniversalRobot."


[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By valdisvi:

This looks like trolling, see also https://github.com/ruby/ruby/pull/4310 and https://github.com/actions/checkout/pull/326


espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Shadyar Khodayari <shadyar81@...>:
4967418a5c2f: several exception words and an unknown charactor added.

Modified: dictsource/fa_list
Modified: dictsource/fa_rules


[espeak-ng/espeak-ng] Pull request closed by jaacoppi:

#899 several exception words and an unknown charactor added.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by trypolis464:

#904 Made the SpeechPlayer code C++, to make it more like the rest of the project

A lot of ESpeak seems to be in C, not C++, so I went ahead and renamed these files, and also updated the makefile. I couldn't find any C++ specific functions, but I could've very well missed something.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Oh dear, my bad, it does at least have using namespace std;, but I'm not sure what from the std namespace it uses.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay yeah I must've been half awake or not checked frame. It uses classes, too. I'd recommend keeping this open though, I'll try to figure out... Something.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay so, what I'm thinking is, move all the properties of the Frame and SpeechWaveGenerator classes into structs, then for the methods, do something like void Frame_doAThing(Frame *theFrame, ...); Thoughts?


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Another thing is that it uses std::queue, std::list, etc. Queue shouldn't be a huge problem, there might be a port of that to C, but not sure about list. I'll see what I can do, and might get another contributor behind this as well.