Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #891 Arabic support
By jaacoppi:

Related to https://github.com/espeak-ng/espeak-ng/issues/864

The problem is that the Visual Studio project files and Wix installer files are incomplete. Someone with experience with Windows development should fix them - could you help?

Looks like this line is missing "ar": https://github.com/espeak-ng/espeak-ng/blob/75ea4b0bdf158bfbbe982241942afaf5367cf80d/src/windows/data.vcxproj#L328

And this file is missing "ar_dict" (and parts of "ja_dict" for japanese: https://github.com/espeak-ng/espeak-ng/blob/master/src/windows/installer/Product.wxs

Could you try to add support for arabic and japanese installers, and them explain how it's done so we can do it later if new languages are added?


[espeak-ng:master] Label added to issue #891 Arabic support by jasondiab.


[espeak-ng:master] New Comment on Issue #891 Arabic support
By jasondiab:

Thank you for your answer. I just saw the issue posted for the Japanese too. It seemed like copying and pasting the ja_dict and ja files to the right directories made it work. I was wondering where I could find the ar_dict file to try it out. Would be great if you could direct me on that end until we find a better fix. I'm not very familiar with Windows development but I will try and take a look at it.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #842 Arabic Long Vowels are Mispronounced
By jasondiab:

Hello @Turkrosoft, how did you get the Arabic to work? I've been having some trouble as addressed in issue #891 Would really appreciate your input.


[espeak-ng:master] New Comment on Issue #891 Arabic support
By jasondiab:

Is there any other way to make it work without going through the installer? By building the project with some changes perhaps or any alternative that might've worked for you? @jaacoppi


[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By gelodefaultbrain:

Hey @gelodefaultbrain I'm having the same issue with the Arabic language, it seems like you found a way to get the ja_dict and paste it into the espeak-ng-data file? If this is the case (or you managed to find another solution) I would appreciate any leads to help me get it to work.

@jasondiab Hello! Yes that's what I did I just got the file and copied them or transferred them to their respective needed locations. Are you using phonemize too?


[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By jasondiab:

I can't find the ar_dict unfortunately in the Source code as you suggested, would be great if you could help (and I'm not using phonemize)


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request closed by jaacoppi:

#888 Set number handling on by default

Can you check my findings and assumptions. This commit will change many languages.

I was instructing someone who is currently adding a new language. They had problems getting numbers working. Nothing in _list was processed. The reason is that number processing is disabled by default. I think it should be on by default so adding a new language is easier. Also see the reasoning in the commit message.

There can be errors if the number definitions are incomplete. The solution would be to fix the number handling code instead of disabling it by default.

I don't speak most of the language affected here. I used a combination of google translate and manually reading the diffs and _list files to figure it out.

If we don't want to change the default behavior we should turn on number processing for those languages that benefit from it and improve documentation in docs/add_language.md to make sure contributors realize to enable number processing.


4 New Commits:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
b0a7ef278927: add macro L4() needed by Klingon (piqd)

Modified: src/libespeak-ng/translate.h


[espeak-ng:master] By jaacoppi <jaacoppi@...>:
a54824c9e59e: voices: Change default number pronunciation rule to enabled.

docs: add details about number flags to the documentation.

It's clearly intended to be enabled by default:
- it's defined as default behaviour translate.h (NUM_DEFAULT)
- tr_languages.c sets many default values related to number processing
that have no meaning unless langopts.numbers == 1.

It is also a more sensible default since most languages will want to
have number processing on. This makes adding new languages easier
because adding an entry to tr_languages.c is unnecessary.

A negative side effect is that languages with partial number defines
might experience bugs when reading undefined numbers. This is a bug and
should be fixed.

This will have the side effect of enabling number processing for
languages that currently have it disabled. However, there shouldn't be
any.

Here's a way to check affected languages:
for voice in $(ESPEAK_DATA_PATH=`pwd` LD_LIBRARY_PATH=src:${LD_LIBRARY_PATH}
src/espeak-ng --voices | grep -v Languages | awk '{print $2}'); do
OUTPUT=$(ESPEAK_DATA_PATH=`pwd` LD_LIBRARY_PATH=src:${LD_LIBRARY_PATH}
src/espeak-ng -qx -v $voice "1 - 2 - 3 - 12 - 123") && echo "$voice:
$OUTPUT" ; done

These voices clearly benefit from enabling numbers (they already have
number rules in *_list):
ba, cmn (zh), hak, haw, ja, kok, nb, nci

Some languages are missing some definitions (like _12) in _list files.
It causes the program to skip some numbers.
Numbering needs to be turned off explicitly for:
jbo, mi, my, piqd, py, qu, quc, th, uz

Languages with no number rules at all:
chr, cv, he, nog, tk, ug

Modified: docs/numbers.md
Modified: src/libespeak-ng/tr_languages.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
1914d39d9f02: Update changelog

Modified: CHANGELOG.md


[espeak-ng:master] By jaacoppi <jaacoppi@...>:
4c3fe183ddb8: Merge pull request #888

Set number handling on by default

Modified: CHANGELOG.md
Modified: docs/numbers.md
Modified: src/libespeak-ng/tr_languages.c
Modified: src/libespeak-ng/translate.h