Topics

Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after

Neither of these versions seem to call PopParamStack or PushParamStack


[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after ""

Neither of these versions seem to call PopParamStack or PushParamStack


[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after /voice

Neither of these versions seem to call PopParamStack or PushParamStack


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

wcslen(xml_buf) is equal to n_xml_buf. strlen(xml_buf) always returns 1 and causes all closing tags to trigger self_closing = true. Somehow the voice change bug is related to the voice stack. Either the return to normal voice points to a wrong index in the buffer, or there's one extra item in the stack.

I'll close this PR, make a new one for the code cleanup and try to find the bug later.


[espeak-ng/espeak-ng] Pull request closed by jaacoppi:

#808 Fix to #737 (ssml voice change) and Cleanup

The fix to #737 happens to work.

I know it's bad practise to fix something without understanding how the fix works, but I'm still doing it. Please check if you can figure out how this change works and whether tests can be added to make sure this doesn't break in the future.

As an added bonus, this simplifies the relationship between ReadClause and ProcessSsmlTag.


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #806 Create language definition file for Ido language
By valdisvi:

Thanks for your contribution! All your commits from pull requests are added into main project: 2bdd9281 bd19024b ba9b054a 0f5316d6 with few fixes from me: 6d3c1dfb changelog and documentation entries for Ido language 925052c3 makefile entries for for Ido language

There is no need to put each commit into separate pull request. In future make necessary commits in your fork of the project and then create single pull request for all related commits.


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#806 Create language definition file for Ido language

Creation of language definition file for Ido language.


[espeak-ng:master] New Comment on Pull Request #805 Create "io_list" for initial Ido language support
By valdisvi:

Look at https://github.com/espeak-ng/espeak-ng/pull/806#issuecomment-676471334


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#805 Create "io_list" for initial Ido language support

Creation of "io_list" file for Ido language


[espeak-ng:master] New Comment on Pull Request #804 Create io_rules for Ido language
By valdisvi:

Look at https://github.com/espeak-ng/espeak-ng/pull/806#issuecomment-676471334


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#804 Create io_rules for Ido language

rThese are the rules for the initial support of Ido language.


[espeak-ng:master] New Comment on Pull Request #803 Update of tr_languages.c for Ido language support
By valdisvi:

Look at https://github.com/espeak-ng/espeak-ng/pull/806#issuecomment-676471334


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#803 Update of tr_languages.c for Ido language support

Hello: I have added initial support for Ido language (similar to Esperanto).


[espeak-ng:master] New Comment on Issue #809 Some wrong pronunciations of German words
By valdisvi:

@hozosch can you comment on this?


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #809 Some wrong pronunciations of German words
By hozosch:

Hmmmm, those words ending in "i" are interesting. They have the wrong stress and pronunciation, but I think your main focus lies on getting rid of the ː symbol in the IPA output. The thing is, my feedback on ESpeak is from a listener's point of view, and not what the phoneme output is. Those "i" sounds are all correct for me, but I may fix the pronunciation of those words, because apart from the, in your view, unnecessary ː, there's also a wrong sounding pronunciation in general.


[espeak-ng:master] New Comment on Issue #809 Some wrong pronunciations of German words
By hozosch:

Hmmmm, those words ending in "i" are interesting. They have the wrong stress and pronunciation, but I think your main focus lies on getting rid of the ː symbol in the IPA output. The thing is, my feedback on ESpeak is from a listener's point of view, and not what the phoneme output is. Those "i" sounds are all correct for me, but I may fix the pronunciation of those words, because apart from the, in your view, unnecessary ː, there's also a wrong sounding pronunciation in general. Profi $1, and shouldn't the "ue" in Muesli be ü?


espeak-ng@groups.io Integration <espeak-ng@...>
 

2 New Commits:

[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
b06f524f3290: Issue #783: add new voices to the synthesizer

Added: espeak-ng-data/voices/!v/Alicia
Added: espeak-ng-data/voices/!v/Demonic
Added: espeak-ng-data/voices/!v/Marco
Added: espeak-ng-data/voices/!v/UniRobot


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
09200187de11: Support up to 350 voices/languages

Modified: src/libespeak-ng/voices.c


[espeak-ng:master] New Comment on Issue #783 Add new voices to the synthesizer.
By valdisvi:

Thanks for contribution! Your voices are added to the project with commit b06f524.


[espeak-ng:master] Issue #783 Add new voices to the synthesizer. closed by comunicationVoices.


espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
85a9e5534076: Update version according to configure.ac, src/windows/config.h and android/jni/include/config.h files

Modified: android/AndroidManifest.xml


[espeak-ng:master] New Comment on Issue #644 F-Droid (Request for packaging) - For info
By valdisvi:

@ArenaL5, I fixed fa_list file with commit cee1870 and AndroidManifest.xml file with commit AndroidManifest.xml 85a9e55 to the current development version.


1 New Commit:

[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
3030884809aa: Fix issue #801: Cherokee language support is broken

Modified: src/libespeak-ng/tr_languages.c