Topics

Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Samuel Thibault <samuel.thibault@...>:
171e8a4e0958: Fix testsuite with /bin/sh being bash

With bash, echo "a\nb" will not interpret \n, while with dash, echo will
interpret \n. bash's echo would need -e, but dash does not know that
option and just prints it.

We can however just put \n litteraly in the script, both bash and dash
will understand it.

Modified: tests/language-pronunciation.test
Modified: tests/translate.test


[espeak-ng/espeak-ng] Pull request closed by rhdunn:

#698 Fix testsuite with /bin/sh being bash

With bash, echo "a\nb" will not interpret \n, while with dash, echo will interpret \n. bash's echo would need -e, but dash does not know that option and just prints it.

We can however just put \n litteraly in the script, both bash and dash will understand it.


[espeak-ng:master] New Comment on Pull Request #698 Fix testsuite with /bin/sh being bash
By rhdunn:

Merged, thanks.

espeak-ng@groups.io Integration <espeak-ng@...>
 

2 New Commits:

[espeak-ng:master] By Reece H. Dunn <msclrhd@...>:
5feff569cc8b: fix #699: -Wlto-type-mismatch when using gcc with -flto=4.

Modified: src/libespeak-ng/setlengths.c


[espeak-ng:master] By Reece H. Dunn <msclrhd@...>:
4e49ac8ee395: Don't check the .git folder for BOM issues.

Modified: tests/bom.test


[espeak-ng:master] Issue #699 Build fails with gcc10 and -fno-common closed by lgbaldoni.


[espeak-ng:master] Label added to issue #699 Build fails with gcc10 and -fno-common by lgbaldoni.


[espeak-ng:master] Label added to issue #699 Build fails with gcc10 and -fno-common by lgbaldoni.


[espeak-ng:master] New Comment on Issue #699 Build fails with gcc10 and -fno-common
By rhdunn:

Thanks for the report. This also occurs with gcc 8 using CFLAGS=flto-4 ./configure.

I have modified the definitions so they match.

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by lgbaldoni:
#699 Build fails with gcc10 and -fno-common

espeak-ng 1.50 on openSUSE Tumbleweed, see log snippet.


[espeak-ng:master] Label removed from issue #699 Build fails with gcc10 and -fno-common by lgbaldoni.


[espeak-ng:master] New Comment on Issue #699 Build fails with gcc10 and -fno-common
By rhdunn:

I can't reproduce that issue locally. It looks like LTO is treating the samplerate in libespeak-ng the same as the one in espeak-ng. Does the following fix the issue?:

diff --git a/src/espeak-ng.c b/src/espeak-ng.c
index 10b8a887..3a7838cf 100644
--- a/src/espeak-ng.c
+++ b/src/espeak-ng.c
@@ -117,7 +117,7 @@ static const char *help_text =
     "--load     Load voice from a file in current directory by name.\n"
     "-h, --help Show this help.\n";
 
-int samplerate;
+static int samplerate;
 bool quiet = false;
 unsigned int samples_total = 0;
 unsigned int samples_split = 0;

If so, I will commit that change.

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Reece H. Dunn <msclrhd@...>:
e11cd42b03d1: fix #699: avoid samplerate clashing with LTO in gcc 10.

Modified: src/espeak-ng.c


[espeak-ng:master] Issue #699 Build fails with gcc10 and -fno-common closed by lgbaldoni.


[espeak-ng:master] Label added to issue #699 Build fails with gcc10 and -fno-common by lgbaldoni.