Topics

Pull Request Opened #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by jaacoppi:

#444 Print an error message if voice is not specified with --compile

Before the change these would segfault: espeak-ng --compile espeak-ng --compile <language>

After the change they print an error message and quit.

This is unchanged and working: espeak-ng --compile=<language>

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by jaacoppi:

#445 portability: use suffix rules instead of pattern rules.

%-style pattern rules are a GNU extension and only used by gnu automake. Suffix rules guarantee portability with non-gnu systems.

Makefile.am already uses suffx rules for documentation (.md.html and .ronn.html), so this also makes the usage more consistent.

Closes #396.

Further reading:https//www.gnu.org/software/make/manual/html_node/Suffix-Rules.html and https://stackoverflow.com/questions/27975545/how-to-deal-with-autoconf-warning-style-pattern-rules-are-a-gnu-make-extens#27975701

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by jaacoppi:

#446 Don't install test libraries with make install

Closes #343. Also disables installing libfuzzrunner which has been implemented after the issue has been raised.

Reece, my commits have been hit and miss lately, so do take extra care checking this one out. I verified this with ./configure --prefix=<PREFIX> && make install./lib doesn't contain the test libraries anymore.