Date   

[espeak-ng:master] reported: Procedure not clear on how to remove/disable a language #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #922 Procedure not clear on how to remove/disable a language
By jbowler:

So far as what @jaacoppi suggests it's pretty trivial to try - just remove src/libespeak-ng/compile*.c from the source files for the library/DLL...

I just tested it, the library builds with no issues. I get (amd64 with -O2):

~/src/espeak-ng/master-build $ size !$/libespeak-ng.so.1.1.51
size src/.libs//libespeak-ng.so.1.1.51
   text    data     bss     dec     hex filename
 479817   31308  111464  622589   97ffd src/.libs/libespeak-ng.so.1.1.51

If I build the library with all the compile support:

~/src/espeak-ng/master-build $ size src/.libs//libespeak-ng.so.1.1.51
   text    data     bss     dec     hex filename
 533092   35708  155976  724776   b0f28 src/.libs//libespeak-ng.so.1.1.51

So that saves over 100k at run-time (text+data+bss). ROM usage depends primarily on the text - data tends to be highly compressible - and that only amounts to 53275 bytes, still that's 10%.

An espeak-ng static build with the "compile" options commented out should just do this automatically, and commenting out the five compile options is easy too...


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By jaacoppi:

So to confirm, I should compile the dictionaries using voice lang yue with zhy rules as well as using voice lang cmn with zhy rules to produce two dictionaries. Doing this seems to produce zhy_dict and zh_dict. If that is the case, it might be better for us just to have an explicit mapping rather than iterate over the files.

Yes, except for the typo (cmn uses zh rules, not zhy).

To say this in another way, at the moment: 1) "espeak-ng --compile=yue" uses zhyrules (and other zhy* files) to produce zhy_dict (Cantonese) 2) both "espeak-ng --compile=cmn" and "espea-ng --compile=zh" use zhrules (and other zh* files) to produce zh_dict (Mandarin)

Once I'm done with the restructuring: 1) --compile=zh will be deprecated (so make sure to start using --compile=cmn for Mandarin to avoid problems in the future) 2) zhy* files will be renamed yue* (you'll need to rename them in your build scripts) 3) zh* files will be renamed cmn* (you'll need to rename them in your build scripts)


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By feerrenrut:

So to confirm, I should compile the dictionaries using voice lang yue with zhy rules as well as using voice lang cmn with zhy rules to produce two dictionaries. Doing this seems to produce zhy_dict and zh_dict. If that is the case, it might be better for us just to have an explicit mapping rather than iterate over the files.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By feerrenrut:

Ok, thanks @jaacoppi. We might go ahead with the work around for now. But it would be good to be able to remove it in the future. On the other hand, perhaps we should have an explicit listing of the voices to use with language rules to produce dictionaries.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #922 Procedure not clear on how to remove/disable a language
By Nafihahmd:

Thank you guys for your valuable replies. I was working on setting up the cross compiling toolchain for a couple days hence the delay in my reply. And to be frank I haven't quite understood what @jbowler had suggested. But I will work on it from today onward. I have started a separate fork where my development will be carried out as you have suggested.


[espeak-ng:master] New Comment on Issue #922 Procedure not clear on how to remove/disable a language
By Nafihahmd:

Thank you guys for your valuable replies. I was working on setting up the cross compiling toolchain for a couple days, hence the delay in my reply. And to be frank I haven't quite understood what @jbowler had suggested. But I will work on it from today onward. I have started a separate fork where my development will be carried out as you have suggested.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By jaacoppi:

I'll try to rename yue_ and cmn_ files this weekend or next week. Looks like it's a bit more complicated than I thought because changes are needed in Android and Windows project files and in the language configuration files.

The dictionary files for Cantonese and Mandarin are different, you'll have to create both.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By feerrenrut:

I misspoke in my last comment (now edited), we are deriving the language codes from the *_rules files not from *_dict files. But if the same offer applies to those files, that would also simplify this.

I have a potential work-around for this nvaccess/nvda#12370 however perhaps we are only creating one dictionary when we should be creating two?


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By jaacoppi:

Would it be easier for NVDA if there was yue_dict and cmn_dict instead of current zhy_dict and zh_dict?

The change for us should be easy since it's mostly about renaming files, not about changing code.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By feerrenrut:

Thanks for the explanations. We are currently splitting the "zhy_rules" to get the language to switch to. I'll add an exception for that language.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By feerrenrut:

Thanks for the explanations. We are currently splitting the "zhy_dict" to get the language to switch to. I'll add an exception for that language.


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By jaacoppi:

The _dict files go to /usr/share/espeak-ng-data/ on a typical install.

That error message seems weird in this situation. Check if you can compile other languages, like English (en). You'll need the files in dictsource/en_rules in your $PWD.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request updated by CMB:

#932 Memory Access Fixes

  • Fix buffer size calculation when initializing output.
  • Fix out-of-bounds read when processing malformed SSML.

These issues were found with valgrind. I am not very confident in the fix for SSML parsing. It does work, but it needs careful review please.


[espeak-ng:master] New Comment on Pull Request #932 Memory Access Fixes
By CMB:

I force-pushed. I tracked down the regression I introduced that was causing readclause.check to fail. translate.check fails for me, but it fails for me at the exact same spot when running from master. So there's no regression there.


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By kanjieater:

espeak-ng --compile=ja

Thank you for the quick reply. I'll try to figure out where to plug that file in now

On Unix i still get:

espeak-ng --compile=ja Error: The specified espeak-ng voice does not exist.

This is reproducible with this Dockerfile: https://gist.github.com/kanjieater/79d86540215facb1cc383bbc73e34c08


[espeak-ng:master] reported: revert faulty code cleanup commit to fix garbled text in some cases #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #929 revert faulty code cleanup commit to fix garbled text in some cases
By jaacoppi:

After listening to espeak-ng "testing ꦒꦩꦼꦭꦤ꧀ testing" I'm certain this PR has no effect. However, it might have an effect when used with the shared library. Next step is to investigate that with tests/api.c


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By jaacoppi:

Thank you for your reply. There are no ja_dict files in the source. Could you please directly link to where the ja_dict file is? Do I need to build it manually with make to find those files?

make will compile it for you. Another option is to use espeak-ng --compile=ja.

I've attached the file here. ja_dict.zip


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By kanjieater:

Yes, on the source code there are the relevant files for ja but when you install the installer and I check on the folder from program files . It is missing. Probably it's just not updated.

Thank you for your reply. There are no ja_dict files in the source. Could you please directly link to where the ja_dict file is? Do I need to build it manually with make to find those files? image

That's strange, japanese should be there and espeak-ng -v ja "わかります" should work.

Can you check that ja_dict is really missing from C:\Program Files\eSpeak NG\/espeak-ng-data

I'm experiencing the same thing on unix image


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By kanjieater:

Yes, on the source code there are the relevant files for ja but when you install the installer and I check on the folder from program files . It is missing. Probably it's just not updated.

Thank you for your reply. There are no ja_dict files in the source. Could you please directly link to where the ja_dict file is? Do I need to build it manually with make to find those files?

That's strange, japanese should be there and espeak-ng -v ja "わかります" should work.

Can you check that ja_dict is really missing from C:\Program Files\eSpeak NG\/espeak-ng-data

I'm experiencing the same thing on unix image


[espeak-ng:master] reported: Can't find Japanese language code. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #864 Can't find Japanese language code.
By gelodefaultbrain:

Yes, on the source code there are the relevant files for ja but when you install the installer and I check on the folder from program files . It is missing. Probably it's just not updated.


[espeak-ng:master] reported: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #933 Unable to compile zhy dictionay on Windows
By rhdunn:

Yes, that's correct. The zhy name is not a valid BCP 47 name. The IANA language subtag registry (based on ISO 636-* for language codes) lists yue for Cantonese and cmn for Mandarin. Other voices have a similar change as well.

In the voice files, the old espeak names are listed as options for compatibility reasons.

The code still refers to them by the old names because they haven't been refactored to align with the changes. The naming of the phoneme files is not consistent either (espeak used the language names, e.g. ph_dutch, but not for cantonese and mandarin for some reason). I just hadn't got around to addressing it, as other things like emoji support were higher priority and I got burned out after that.


[espeak-ng:master] new issue: Unable to compile zhy dictionay on Windows #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by feerrenrut:
#933 Unable to compile zhy dictionay on Windows

The NVDA project has had an issue open for a while. We'd like to ask for some assistance to identify the issue. This process works for all other languages.

Our build script for espeak dictionaries: - Calls espeak_Initialize - Constructs a espeak_VOICE struct (see struct definition below) with language set to zhy\0 - Calls espeak_SetVoiceByProperties which returns 2 (ENS_VOICE_NOT_FOUND)

Struct:

class espeak_VOICE(ctypes.Structure):
	_fields_=[
		('name',ctypes.c_char_p),
		('languages',ctypes.c_char_p),
		('identifier',ctypes.c_char_p),
		('gender',ctypes.c_byte),
		('age',ctypes.c_byte),
		('variant',ctypes.c_byte),
		('xx1',ctypes.c_byte),
		('score',ctypes.c_int),
		('spare',ctypes.c_void_p),
	]

Thanks!

561 - 580 of 4633