Date   

Pull Request Updated #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request updated by trypolis464:

#904 Made the SpeechPlayer code C++, to make it more like the rest of the project

A lot of ESpeak seems to be in C, not C++, so I went ahead and renamed these files, and also updated the makefile. I couldn't find any C++ specific functions, but I could've very well missed something.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay so, what I'm thinking is, move all the properties of the Frame and SpeechWaveGenerator classes into structs, then for the methods, do something like void Frame_doAThing(Frame *theFrame, ...); Thoughts?


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Another thing is that it uses std::queue, std::list, etc. Queue shouldn't be a huge problem, there might be a port of that to C, but not sure about list. I'll see what I can do, and might get another contributor behind this as well.


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By valdisvi:

No. That was info for @jaacoppi.


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By shadyar:

@valdisvi Thanks so much. Is there some thing I should do about this issue?


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By valdisvi:

I checkout pull request into new local branch and after checks merge branch into master branch.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by trypolis464:

#904 Made the SpeechPlayer code C++, to make it more like the rest of the project

A lot of ESpeak seems to be in C, not C++, so I went ahead and renamed these files, and also updated the makefile. I couldn't find any C++ specific functions, but I could've very well missed something.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Oh dear, my bad, it does at least have using namespace std;, but I'm not sure what from the std namespace it uses.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay yeah I must've been half awake or not checked frame. It uses classes, too. I'd recommend keeping this open though, I'll try to figure out... Something.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
dbaf6d4012e7: Update changelog

I forgot to add fa: to previous commit message 4967418.

Modified: CHANGELOG.md


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By jaacoppi:

Thanks for the commit.

Note about git: I did git merge but didn't notice the message: Fast-forward (no commit created; -m option ignored) That's why there's no "Merge pull request #899" message. I'm not sure if this is a problem or not.

So far all merges I've done have created the commit message. Should I have used --no-ff?


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Shadyar Khodayari <shadyar81@...>:
4967418a5c2f: several exception words and an unknown charactor added.

Modified: dictsource/fa_list
Modified: dictsource/fa_rules


[espeak-ng/espeak-ng] Pull request closed by jaacoppi:

#899 several exception words and an unknown charactor added.


[espeak-ng:master] closed: How can I X?#github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] Issue #903 How can I X? closed by mary-doc.


[espeak-ng:master] new issue: How can I X? #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by mary-doc:
#903 How can I X?

Originally posted by @mary-doc in https://github.com/conventional-changelog/standard-version/issues/733


[espeak-ng:master] reported: eSpeak-ng detects a sentence only if the next one starts with a capital letter #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #872 eSpeak-ng detects a sentence only if the next one starts with a capital letter
By jaacoppi:

They advised their use case for this was that they do not use capitals in Georgia (I believe the European country rather than the US state).

In that case we really should have an option to choose whether to pause on capitals only or also with lowercase.

The change requires: 1. read the option in voices.c / LoadVoice() 2. check for the option in readclause.c / ReadClause() 3. add the option to Georgian voice file espeak-ng-data/lng/ccs/ka 4. document the option in docs/voices.md 5. add a test 6. collect feedback from users to see if it really works as intended

I'm busy at the moment but hopefully I'll be able to implement this in April.

Edit: P.S. According to https://en.wikipedia.org/wiki/Georgian_language "In Mkhedruli, there is no case."


[espeak-ng:master] reported: eSpeak-ng detects a sentence only if the next one starts with a capital letter #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #872 eSpeak-ng detects a sentence only if the next one starts with a capital letter
By jaacoppi:

They advised their use case for this was that they do not use capitals in Georgia (I believe the European country rather than the US state).

In that case we really should have an option to choose whether to pause on capitals only or also with lowercase.

The change requires: 1. read the option in voices.c / LoadVoice() 2. check for the option in readclause.c / ReadClause() 3. add the option to Georgian voice file espeak-ng-data/lng/ccs/ka 4. document the option in docs/voices.md 5. add a test 6. collect feedback from users to see if it really works as intended

I'm busy at the moment but hopefully I'll be able to implement this in April.

Edit: P.S. According to https://en.wikipedia.org/wiki/Georgian_language "In Mkhedruli, there is no case."


[espeak-ng:master] closed: Makes sense! Reverting back here 😋#github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] Issue #902 Makes sense! Reverting back here 😋 closed by mary-doc.


[espeak-ng:master] new issue: Makes sense! Reverting back here 😋 #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by mary-doc:
#902 Makes sense! Reverting back here 😋

Makes sense! Reverting back here 😋

Originally posted by @manniL in https://github.com/nuxt/nuxt.js/pull/8630#discussion_r556083165

Originally posted by @mary-doc in https://github.com/actions/example-services/issues/55

Originally posted by @mary-doc in https://github.com/github/markup/issues/1458


[espeak-ng:master] reported: eSpeak-ng detects a sentence only if the next one starts with a capital letter #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #872 eSpeak-ng detects a sentence only if the next one starts with a capital letter
By Qchristensen:

I had a report from a user who is encountering this issue with eSpeak-NG not pausing after a sentence because they do not start the next sentence with a capital letter.

They advised their use case for this was that they do not use capitals in Georgia (I believe the European country rather than the US state).


[espeak-ng:master] new issue: Same voice file and same command line for espeak and espeak-ng, but different result? #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by iUltimateLP:
#901 Same voice file and same command line for espeak and espeak-ng, but different result?

Hey there! I'm currently trying out espeak-ng and I generated a robot-like voice with both espeak and espeak-ng, however, both sound different.

The command line used for both sound files:

-m -w out.wav "<voice name=\"mb-us2\"><prosody pitch=\"0\" rate=\"0.65\" range=\"0\"><break time=\"0s\" />I'M A ROBOT. ACTION EXECUTED. TERMINATED. ERROR IN PROGRAM.</prosody></voice>" -v mb-us2 -g 2 -a 50

The weird 0s break is somehow needed as otherwise the pitch won't be kept constant. I'm also using the mbrola us2 voice as you can see.

Here's the result with the plain old eSpeak: https://drive.google.com/file/d/16KQFXQ_QKp7Vyb3osCIeRhU-khq-fEwU/view And here's the result with espeak-ng: https://drive.google.com/file/d/1iuxx8MY150KXYTiKr1piRugc4gyuAYrv/view?usp=sharing

As you can hear, the old eSpeak produced a higher pitch (I was also wondering why since pitch is set to 0), but it sounds cleaner and less like the actual mb-us2 voice, while espeak-ng produces a whole different result which I wasn't so satisfied with. Any ideas? Thanks.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By valdisvi:

This looks like trolling, see also https://github.com/ruby/ruby/pull/4310


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#900 Revert "Fixed a typo in UniversalRobot."


[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By valdisvi:

This looks like trolling, see also https://github.com/ruby/ruby/pull/4310 and https://github.com/actions/checkout/pull/326


[espeak-ng:master] reported: Revert "Fixed a typo in UniversalRobot." #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By valdisvi:

There are several configuration files where DOS-style linebreaks are used (e.g. Alicia, Andy, Annie, etc.) and which work without problems.


[espeak-ng:master] reported: Revert "Fixed a typo in UniversalRobot." #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #900 Revert "Fixed a typo in UniversalRobot."
By jaacoppi:

Why are you reverting this? Please always add a description to pull requests.

I can't test this right now, but looks like the commit that fixes a typo also includes a ^M at the end of the line, which might cause UniversalRobot to stop working. I this the reason for the revert?

861 - 880 of 4781