Date   

Pull Request Opened #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by valdisvi:

#907 Remove duplicated code from test scripts

To be sure that I didn't introduce regressions, I checked that tests pass after each commit. Attached file shows difference between output before and after refactoring: output-diff.txt


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By raminhalavati:

Thank you. I will follow up the issue with Talkback and look back.


[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By raminhalavati:

Thank you. I will follow up the issue with Talkback and loop back.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #906 Regression: en+klatt4 voice produces different/random wave output
By valdisvi:

It looked like it was problem on my computer. Full reconfiguration and rebuild fixed this issue.


[espeak-ng:master] Issue #906 Regression: en+klatt4 voice produces different/random wave output closed by valdisvi.


[espeak-ng:master] new issue: Regression: en+klatt4 voice produces different/random wave output #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by valdisvi:
#906 Regression: en+klatt4 voice produces different/random wave output

Run following command with most recent espeak-ng build:

make check

and note that one of tests fail:

testing en+klatt4 ... 
1c1
< 377767780368115863cde5cc11c0203cfdd48476
---
> 22614e6fa2882ab58eef4e9fccf534287d5747f5

also note, that actual sha1sum is changing randomly, which you can check with just command:

espeak-ng -ven+klatt4 "The quick brown fox jumps over the lazy dog" --stdout|sha1sum

If you run it with older build of espeak-ng, then wav output is always the same:

377767780368115863cde5cc11c0203cfdd48476 

If you listen to produced sound, e.g. with just:

espeak-ng -ven+klatt4 "The quick brown fox jumps over the lazy dog"

then additional clipping/popping sounds appear for consonants.


[espeak-ng:master] reported: eSpeak-ng detects a sentence only if the next one starts with a capital letter #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #872 eSpeak-ng detects a sentence only if the next one starts with a capital letter
By jaacoppi:

I just pushed https://github.com/espeak-ng/espeak-ng/commit/c4740b30533ee0010b6adf23b25483f14bcbbc47 and https://github.com/espeak-ng/espeak-ng/commit/cad1c8e87fcccf677a445202e340f61980450a84. They should be enough to close this issue.

@vortex1024: add "lowercaseSentence" to your language files in espeak-ng-data/lang/* and see if this is exactly what you wanted or if there should be something else.

@Qchristensen: The option is now set on by default for Georgian, but not any other language. Please gather feedback from your users or point them here directly.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

2 New Commits:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
c4740b30533e: New language option lowercaseSentence

When set in a language file, a period followed by a lower case letter is
detected as end of sentence. Normal behavior is to require a capital
letter.

Added: tests/voices.test
Modified: .gitignore
Modified: CHANGELOG.md
Modified: Makefile.am
Modified: docs/voices.md
Modified: espeak-ng-data/lang/ccs/ka
Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/tr_languages.c
Modified: src/libespeak-ng/translate.h
Modified: src/libespeak-ng/voices.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
cad1c8e87fcc: ka: End sentences for period followed by a lower case letter.

Useful because capitals are not used in Mkhedruli script.

Uses the new lowercaseSentence setting.

Modified: espeak-ng-data/lang/ccs/ka


[espeak-ng:master] reported: eSpeak/TalkBack issue when language tag is not provided. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By shadyar:

Persian characters mainly are intersection with Arabic characters , so that eSpeak is not able to distincts the pronunciation language from a given string. By default espeak supposes when a given string contains Arabic characters, without any language span, its pronunciation language is Arabic. There is not reliable method to discriminate between Arabic and Persian from the characters. In this case eSpeak attempts to speech a given string in Persian by its Arabic rules. I suggest, Talk-Back should not send strings without language span or blank language span. When a web content does not have language tag, Talk-Back should fill language span with the same language chosen as default user TTS language.


[espeak-ng:master] reported: eSpeak/TalkBack issue when language tag is not provided. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #905 eSpeak/TalkBack issue when language tag is not provided.
By valdisvi:

Pronunciation language in Android is set manually by application preferences.


[espeak-ng:master] new issue: eSpeak/TalkBack issue when language tag is not provided. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by raminhalavati:
#905 eSpeak/TalkBack issue when language tag is not provided.

Hi,

If you go through the following steps (on Android): - Install eSpeak as TTS and set it's language to Persian. - Select eSpeak as the default TTS for Talkback. - Go to Chrome and navigate to http://bit.ly/irprogrammers. The page is in Persian (Farsi), but doesn't have a language tag.

You can observe that instead of reading the page in Persian, it reads it as English/Arabic and one letter at a time. I raised the issue to the TalkBack team and they said: "In case the webpage-content or talkback-language-preference provide locale-span, Talkback is sending the language through locale-span, but it seems that eSpeak is ignoring it." and "locale-span-language would be set by the talkback-language-preference, or no locale-span-language if no talkback-language-preference is set."

Is it something that you can take a look at? Or is there any issue that needs to be fixed on the talkback side and I can follow up?

@shadyar


Pull Request Updated #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request updated by trypolis464:

#904 Made the SpeechPlayer code C++, to make it more like the rest of the project

A lot of ESpeak seems to be in C, not C++, so I went ahead and renamed these files, and also updated the makefile. I couldn't find any C++ specific functions, but I could've very well missed something.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay so, what I'm thinking is, move all the properties of the Frame and SpeechWaveGenerator classes into structs, then for the methods, do something like void Frame_doAThing(Frame *theFrame, ...); Thoughts?


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Another thing is that it uses std::queue, std::list, etc. Queue shouldn't be a huge problem, there might be a port of that to C, but not sure about list. I'll see what I can do, and might get another contributor behind this as well.


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By valdisvi:

No. That was info for @jaacoppi.


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By shadyar:

@valdisvi Thanks so much. Is there some thing I should do about this issue?


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By valdisvi:

I checkout pull request into new local branch and after checks merge branch into master branch.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by trypolis464:

#904 Made the SpeechPlayer code C++, to make it more like the rest of the project

A lot of ESpeak seems to be in C, not C++, so I went ahead and renamed these files, and also updated the makefile. I couldn't find any C++ specific functions, but I could've very well missed something.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Oh dear, my bad, it does at least have using namespace std;, but I'm not sure what from the std namespace it uses.


[espeak-ng:master] New Comment on Pull Request #904 Made the SpeechPlayer code C++, to make it more like the rest of the project
By trypolis464:

Okay yeah I must've been half awake or not checked frame. It uses classes, too. I'd recommend keeping this open though, I'll try to figure out... Something.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
dbaf6d4012e7: Update changelog

I forgot to add fa: to previous commit message 4967418.

Modified: CHANGELOG.md


[espeak-ng:master] reported: several exception words and an unknown charactor added. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #899 several exception words and an unknown charactor added.
By jaacoppi:

Thanks for the commit.

Note about git: I did git merge but didn't notice the message: Fast-forward (no commit created; -m option ignored) That's why there's no "Merge pull request #899" message. I'm not sure if this is a problem or not.

So far all merges I've done have created the commit message. Should I have used --no-ff?


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Shadyar Khodayari <shadyar81@...>:
4967418a5c2f: several exception words and an unknown charactor added.

Modified: dictsource/fa_list
Modified: dictsource/fa_rules


[espeak-ng/espeak-ng] Pull request closed by jaacoppi:

#899 several exception words and an unknown charactor added.


[espeak-ng:master] closed: How can I X?#github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] Issue #903 How can I X? closed by mary-doc.


[espeak-ng:master] new issue: How can I X? #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by mary-doc:
#903 How can I X?

Originally posted by @mary-doc in https://github.com/conventional-changelog/standard-version/issues/733

861 - 880 of 4790