Date   

[espeak-ng:master] reported: consecutive SSML tags aren't processed #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #410 consecutive SSML tags aren't processed
By jaacoppi:

https://github.com/espeak-ng/espeak-ng/blob/0cb4b1b6542666919ae8b177f7bdb045e84e55ab/src/libespeak-ng/ssml.c#L704-L705 adding a return CLAUSE_NONE; here seems to solve the problem, but create others because the sentence end is not an intended consequence.

Something is done during the sentence end that causes the values for speech_parameters or param_stack to be read. Currently they seem to be set but not read.


[espeak-ng:master] reported: Please Someone add Sanskrit and Hmong #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #887 Please Someone add Sanskrit and Hmong
By Animegirl3:

@valdisvi Please add Sanskrit and Hmong but I like experimenting these asian languages voices and I am curious Please add it in the demo odo.lv/Espeak Thank you @valdisvi


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 


[espeak-ng:master] new issue: Please Someone add Sanskrit and Hmong #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by Animegirl3:
#887 Please Someone add Sanskrit and Hmong


[espeak-ng:master] reported: code cleanup: remove ssml_ignore_l_angle. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #886 code cleanup: remove ssml_ignore_l_angle.
By valdisvi:

@michaelDCurran, @feerrenrut, probably NVDA community is the most active users of SSML features of the eSpeak NG. Can you comment on this?


Pull Request Opened #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request opened by jaacoppi:

#886 code cleanup: remove ssml_ignore_l_angle.

It looks like ssml_ignore_l_angle is just dead code. Can you find any use for it?

It is only set in AnnouncePunctuation if end_clause != 0. Even when manually setting ssml_ignore_l_angle there seems to be no effect on anything.

For example, this doesn't change after the commit: src/espeak-ng -m --punct "<speak>Here's a &lt; and a &amp;, and < and &. This is still &lt;(&lt;)(&lt;)</speak>"

If a use case for this is found it should be better documented.

looks like commit 1a2f454af378 from 2008 was first to have ssml_ignore_l_angle in AnnouncePunctuation.


[espeak-ng:master] reported: SSML <audio> garbles 8-bit wavs #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #885 SSML garbles 8-bit wavs
By valdisvi:

I don't know either, but if espeak-ng uses command line interface of sox, adding this parameter looks ok to me.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #885 SSML garbles 8-bit wavs
By jaacoppi:

The solution for this looks simple.

https://github.com/espeak-ng/espeak-ng/blob/0cb4b1b6542666919ae8b177f7bdb045e84e55ab/src/libespeak-ng/readclause.c#L352

Adding a -b 16 option to sox forces the original audio to 16 bits. It shouldn't affect files that are already 16 bits, but fixes playing 8 bit wavs.

MP3 files seem to be unaffected by this bug anyway. I didn't check with any other file types.

Do you think I should push this -b 16 or this there something that I'm missing? I don't know much about audio playback in espeak-ng.


[espeak-ng:master] New Comment on Issue #885 SSML garbles 8-bit wavs
By jaacoppi:

The solution for this looks simple.

https://github.com/espeak-ng/espeak-ng/blob/0cb4b1b6542666919ae8b177f7bdb045e84e55ab/src/libespeak-ng/readclause.c#L352

Adding a -b 16 option to sox forces the original audio to 16 bits. It shouldn't affect files that are already 16 bits, but fixes playing 8 bit wavs.

MP3 files seem to be unaffected by this bug anyway. I didn't check with any other file types.

Do you think I should push this -b 16 or is there something that I'm missing? I don't know much about audio playback in espeak-ng.


[espeak-ng:master] reported: SSML <audio> garbles 8-bit wavs #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #885 SSML garbles 8-bit wavs
By valdisvi:

As far as I know, espeak-ng supports only one single wav format: PCM, 16 bit, mono 22050 Hz, therefore #88 is marked as a feature request.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

2 New Commits:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
c62921ae0bae: tests: add tests for ssml <prosody> and <audio>

SSML logic has a bug (#410) where speech parameters are not changed when there's a
sentence elogic nd. The prosody bug test should fail.

Modified: tests/ssml.test


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
0cb4b1b65426: docs: add sox as an optional dependency.

using sox for ssml <audio> tag is hardcoded in readclause.c and for
--compile-phonemes in compiledict.c

Currently, --compile-phoneme doesn't need to run sox since the
samplerate for the specific file is correct. There might be a lot of
dead code in compiledata.c

Modified: docs/building.md


[espeak-ng:master] Label added to issue #864 Can't find Japanese language code. by gelodefaultbrain.


[espeak-ng:master] new issue: SSML <audio> garbles 8-bit wavs #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by jaacoppi:
#885 SSML garbles 8-bit wavs

This works with 16 bit wavs:

src/espeak-ng -m "<speak>This works: <audio src=\"$PWD/phsource/h/ha.wav\"></speak>"

file phsource/h/ha.wav
phsource/h/ha.wav: RIFF (little-endian) data, WAVE audio, Microsoft PCM, 16 bit, mono 22050 Hz

However, if the file is an 8-bit file (for example converted with sox input.wav -b 8 output.wav), the output of the wav is garbled.

Possibly related to #88.


[espeak-ng:master] reported: Problem reading Polish letter ó. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #884 Problem reading Polish letter ó.
By Qchristensen:

I asked my user for more details, and they advised they have resolved the issue by using NDVA's symbol pronunciation dailog, adding an entry for ó and having it read as u, which they advised works for them.

I don't have any further information on it, so if no-one else is reporting it and you're confident that it's working as it should already, I'm happy for this to be closed.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
19e2f697f63a: code cleanup: remove unnecessary current_voice_id in readclause.c

Instead of passing a temporary variable current_voice_id to SSML
processing logic and then copying the value to voice_change, pass
voice_change directly. GetVoiceAttributes() both sets voice_change and
retuns CLAUSE_TYPE_VOICE_CHANGE that is used by TranslateClause() for
error checking.

tests/ssml/language-switch.ssml covers the intended behavior of language
switching and will fail when either voice_change or CLAUSE_TYPE_VOICE_CHANGE
is not set correctly.

Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/ssml.c


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by jasondiab:
#882 Trouble adding new language

[e


[espeak-ng:master] Issue #882 Trouble adding new language closed by jasondiab.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
cc5b1e1119c4: code cleanup: reorganize check for u.s.a.'s in int ReadClause()

This approach reduces the amount of nested if statements and doesn't
require the temporary variable int c_next_2.

A test already exists for this case in tests/translate.test

Modified: src/libespeak-ng/readclause.c


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
d1332d7f35f8: code cleanup: remove unnecessary text_buf2

Modified: src/libespeak-ng/readclause.c


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
5d92b336f53f: code cleanup: remove unnecessary pointer assignment and enum value.

- V_ALPHABET2 is a leftover from 2f8f125.
- langopts assignment is unnecessary since it's not used later in the
function.

Modified: src/libespeak-ng/voices.c


[espeak-ng:master] reported: Problem reading Polish letter ó. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #884 Problem reading Polish letter ó.
By jaacoppi:

Can you explain a bit more? Is the problem same with all words? Is the problem only with the pronunciation of ó, or does it affect the rest of the word in some way?

Everything seems to work. Last Polish-specific changes have been made in 2018.

Here's a debug example: espeak-ng -v pl -qx -X "którym ó"

Flags: którym $u+ $strend Translate 'którym' 1 k [k]

1 t [t]

36 ó [u]

1 r [R]

1 y [y]

1 m [m] 22 m (_ [m_]

Translate 'ó' 36 ó [u]

kt,uRym_ 'u


[espeak-ng:master] new issue: Problem reading Polish letter ó. #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by Qchristensen:
#884 Problem reading Polish letter ó.

One of our NVDA users reported an issue in recent NVDA versions reading the Polish letter ó. They advised that eSpeak-NG simply cuts it off.

NVDA 2020.4 (and the previous version 2020.3) use eSpeak-NG 1.51-dev, commit 1fb68ffffea4


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
124393733408: code cleanup: remove unused width2.

It is set but never used.

Modified: src/libespeak-ng/voice.h
Modified: src/libespeak-ng/voices.c

821 - 840 of 4647