Date   

Pull Request Updated #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng/espeak-ng] Pull request updated by jaacoppi:

#813 SSML cleanup

Move SSML related logic from ReadClause to ProcessSsmlTag and to a new function ParseSsmlReference().

Contributes to #369 and should make locating SSML bugs easier.


[espeak-ng:master] reported: SSML cleanup #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By jaacoppi:

I didn't even notice the test failing as it was added later.

Running this on current master branch: espeak-ng --punct -x -m -f input.txt with input.txt being a simple one liner <!-- Commenting --><speak>&apos;</speak> Produces: gr'eIt@D,an_: t'Ik.

That is clearly wrong. It seems that the current way of handling combination of comments and entity references is broken somehow, and 34657e7 fixes it. My aim was to change nothing, just reorganize the code, so I certainly don't know why this is happening.

The extra spaces in references.ssml2 are there by accident. I can add a commit for reformatting. Is this good?

<speak>&lt; &gt; &amp; &apos; &quot;</speak>
<speak>B &#66;</speak>
<speak>z &#x7A;</speak>


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By valdisvi:

I think, it is old problem which will be fixed, please add commit to make xml formatted nicer, and I'll merge it. In future, it is better to start by adding test before refactoring. That will allow to ensure, that it either didn't come worse, or it actually fixes some problem which was not found before.


[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By valdisvi:

I think, it is old problem which will be fixed. Please add commit to make xml formatted nicer, and I'll merge it. In future, it is better to start by adding test before refactoring. That will allow to ensure, that it either didn't come worse, or it actually fixes some problem which was not found before.


[espeak-ng:master] reported: SSML cleanup #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By jaacoppi:

I didn't even notice the test failing as it was added later.

Running this on current master branch: espeak-ng --punct -x -m -f input.txt with input.txt being a simple one liner <!-- Commenting --><speak>&apos;</speak> Produces: gr'eIt@D,an_: t'Ik.

That is clearly wrong. It seems that the current way of handling combination of comments and entity references is broken somehow, and 34657e7 fixes it. My aim was to change nothing, just reorganize the code, so I certainly don't know why this is happening.

The extra spaces in references.ssml2 are there by accident. I can add a commit for reformatting. Is this good? < > & ' " B B z z


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By valdisvi:

To check for regressions, I first cherry-picked only commit 959bf26 and run make check with everything else the same. I got error:

testing tests/ssml/references.ssml2
1c1
< l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
---
> gr'eIt@D,an_: l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
make: *** [Makefile:2654: tests/ssml.check] Error 1

Does it means, that current implementation actually is broken and doesn't work as expected? Why in tests/ssml/references.ssml2

<speak> &lt; &gt; &amp; &apos; &quot; </speak>
<speak> B &#66;</speak>
<speak>z &#x7A;</speak>

with all commits applied it works with spaces removed.


[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By valdisvi:

To check for regressions, I first cherry-picked only commit 959bf26 and run make check with everything else the same. I got error:

testing tests/ssml/references.ssml2
1c1
< l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
---
> gr'eIt@D,an_: l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
make: *** [Makefile:2654: tests/ssml.check] Error 1

Does it means, that current implementation actually is broken and doesn't work as expected? Why in tests/ssml/references.ssml2 are unneded spaces?

<speak> &lt; &gt; &amp; &apos; &quot; </speak>
<speak> B &#66;</speak>
<speak>z &#x7A;</speak>

with all commits applied it works with these spaces removed.


[espeak-ng:master] New Comment on Pull Request #813 SSML cleanup
By valdisvi:

To check for regressions, I first cherry-picked only commit 959bf26 and run make check with everything else the same. I got error:

testing tests/ssml/references.ssml2
1c1
< l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
---
> gr'eIt@D,an_: l'EsDan_: gr'eIt@D,an_: 'amp@s,and t'Ik_: kw'oUts
make: *** [Makefile:2654: tests/ssml.check] Error 1

Does it means, that current implementation actually is broken and doesn't work as expected? Why in tests/ssml/references.ssml2 are unneded spaces?

<speak> &lt; &gt; &amp; &apos; &quot; </speak>
<speak> B &#66;</speak>
<speak>z &#x7A;</speak>

with all commits applied it works with these spaces removed.


[espeak-ng:master] reported: SSML input <voice name="value" age="value"> changes to default voice mid-sentence #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #737 SSML input changes to default voice mid-sentence
By jaacoppi:

One options is to parse the XML as a document.

That's the long term plan in #369. I've been restructuring SSML support for a while now. However, the code is filled with global variables so restructuring is not easy.


[espeak-ng:master] reported: SSML input <voice name="value" age="value"> changes to default voice mid-sentence #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #737 SSML input changes to default voice mid-sentence
By guest271314:

One options is to parse the XML as a document.


[espeak-ng:master] reported: SSML input <voice name="value" age="value"> changes to default voice mid-sentence #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #737 SSML input changes to default voice mid-sentence
By jaacoppi:

Looks like is_end_clause or end_clause_after_tag have something to do with this. For example, removing these lines fixes the issue (but break something else): https://github.com/espeak-ng/espeak-ng/blob/5deac40b1a3804b46cc8539d731ad7f2608671ff/src/libespeak-ng/readclause.c#L1111-L1116

I'll keep posting here until I find a solution


[espeak-ng:master] new issue: Wrong tone sandhi #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by ferrumcccp:
#815 Wrong tone sandhi

$ espeak -q -vzh -x "展览馆,好旅馆" # Which means "exhibition hall, good hotel"
ts.'a35n_| l'a35n_| kw'a214n_|
X'Au35_| l'y35_| kw'a214n_|

The correct pronunciation should be:

ts.'a35n_| l'a35n_| kw'a214n_|
X'Au214_| l'y35_| kw'a214n_|

Because "好旅馆" is two words and tone sandhi should be applied separately.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #811 Improved Interlingua voice
By valdisvi:

Thanks for contribution! It is included into the project with commit 5deac40. Some notes: 1. as word list is very long, it is put in file ia_listx, where extended list of words is usually stored, except 2. pronunciation of numbers are put into updated ia_list file. 3. file had two different rules for the same word:

le	$nounf $u+
le 	$verb $verbextend $u

I left only first entry in ia_list file.

  1. There were capital first letters used for written words, these were converted to lowercase, because espeak-ng rules don't care about case of letters in written form. If you need to care about them, additional flag (e.g. $capital or $allcaps) should be added after pronunciation.

To use MBROLA Italian voice for Interlingua, look MBROLA voices guide and mb-it1 and it1 files as examples.


[espeak-ng:master] Issue #811 Improved Interlingua voice closed by nesrad.


Github push to espeak-ng:espeak-ng #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

1 New Commit:

[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
5deac40b1a38: Fix issue #811: improve Interlingua language

Added: dictsource/ia_listx
Modified: CHANGELOG.md
Modified: Makefile.am
Modified: dictsource/ia_list
Modified: tests/language-pronunciation.test


[espeak-ng:master] reported: PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By valdisvi:

It may be included as another utility in tools with separately called make tasks. Look at emoji script and corresponding Makefile.am entry to call it for building.


[espeak-ng:master] reported: PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By repodiac:

Docker is used for a "turn-key" solution - no manual download or anything, just hit the button when you want the most recent file update, so to speak. It is all source code so if you are tech-savvy enough you can simply run -- or invoke the method even -- the script for yourself ;-)

However, all this does not answer my initial request: Either you might include it into your build/deploy process (as the tutorial says... there are "Compile errors" sometimes) or you might link somewhere to the repo for anyone interested in enriching his German phoneme dictionary!?


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By valdisvi:

Solution seems interesting and may be useful for other languages, where pronunciation is not easy deducted from writing. But I'm wondering why it needs docker to run Python script.


[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By valdisvi:

Solution seems interesting and may be useful for other languages, where pronunciation is not easy deducted from writing. But I'm wondering, why it needs docker to run Python script.


[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By repodiac:

Docker is used for a "turn-key" solution - no manual download or anything, just hit the button when you want the most recent file update, so to speak. It is all source code so if you are tech savy enough you can simply run -- or invoke the method even -- the script for yourself ;-)

However, all this does not answer my initial request: Either you might include it into your build/deploy process (as the tutorial says... there are "Compile errors" sometimes) or you might link somewhere to the repo for anyone interested in enriching his German phoneme dictionary!?


[espeak-ng:master] reported: PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By repodiac:

See https://foundation.wikimedia.org/wiki/Terms_of_Use/en for the Terms of use. I think attribution must be done properly but other than that there shouldn't be any problems.

Well, I am not a lawyer into IP... but yes, it seems if you stick to "share alike" with the usage (i.e. to my understanding, nobody is for instance, allowed to make money with this data under a proprietary license...) it should be ok - what's espeak-ng's precise license on data usage btw.?

How easy would it be to use the script for other languages?

Generally speaking: it should be possible. I parse for specific strings in German coming from the markup and surroundings. In other languages, as I assume, there is the same markup but in another language!? But I don't know if other languages in Wiktionary also specify provenance of words (i.e. loan words)... but if so, then it should be straight forward.

The code is documented - but I can "guide" you if you want to use it also for another specific language, where to replace the respective strings probably. Everything from then onward stays the same.


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By repodiac:

See https://foundation.wikimedia.org/wiki/Terms_of_Use/en for the Terms of use. I think attribution must be done properly but other than that there shouldn't be any problems.

Well, I am not a lawyer into IP... but yes, it seems if you stick to "share alike" with the usage (i.e. to my understanding, nobody is for instance, allowed to make money with this data under a proprietary license...) it should be ok - what's espeak-ng's precise license on data usage btw.?

How easy would it be to use the script for other languages?

Generally speaking: it should be possible. I parse for specific strings in German coming from the markup and surroundings. In other languages, as I assume, there is the same markup but in another language!? But I don't know if other languages in Wiktionary also specify provenance of words (i.e. lean words)... but if so, then it should be straight forward.

The code is documented - but I can "guide" you if you want to use if for a specific language, where to replace the respective strings probably. Everything from then onward stays the same.


[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By repodiac:

See https://foundation.wikimedia.org/wiki/Terms_of_Use/en for the Terms of use. I think attribution must be done properly but other than that there shouldn't be any problems.

Well, I am not a lawyer into IP... but yes, it seems if you stick to "share alike" with the usage (i.e. to my understanding, nobody is for instance, allowed to make money with this data under a proprietary license...) it should be ok - what's espeak-ng's precise license on data usage btw.?

How easy would it be to use the script for other languages?

Generally speaking: it should be possible. I parse for specific strings in German coming from the markup and surroundings. In other languages, as I assume, there is the same markup but in another language!? But I don't know if other languages in Wiktionary also specify provenance of words (i.e. lean words)... but if so, then it should be straight forward.

The code is documented - but I can "guide" you if you want to use it also for another specific language, where to replace the respective strings probably. Everything from then onward stays the same.


[espeak-ng:master] reported: PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By jaacoppi:

See https://foundation.wikimedia.org/wiki/Terms_of_Use/en for the Terms of use. I think attribution must be done properly but other than that there shouldn't be any problems.

How easy would it be to use the script for other languages?


Updates to Github #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by repodiac:
#814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary

Hi,

I've written a small script and tutorial to extract roughly 10k German loan words from the German wiktionary, use their IPA code and convert it into Kirshenbaum syntax for import as dictionary (de_extra) into espeak-ng.

If you're interested (don't know about possible license issues with wiktionary data) you could take this as a PR or alternatively, link to my repo for the curious reader/user.

https://github.com/repodiac/espeak-ng_german_loan_words


[espeak-ng:master] New Comment on Issue #814 PR: Approx. 10,000 German loan words from DE-Wiktionary could be added to espeak-ng dictionary
By hozosch:

Well, this certainly sounds very exciting! I don't have the permission to merge this though.


[espeak-ng:master] reported: SSML input <voice name="value" age="value"> changes to default voice mid-sentence #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Issue #737 SSML input changes to default voice mid-sentence
By jaacoppi:

Issue doesn't exist with espeak-ng --punct -m -f input.txt. I'll keep looking.


[espeak-ng:master] new issue: Improved Interlingua voice #github

espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Issue Created by nesrad:
#811 Improved Interlingua voice

Hi, I've created the file ia_list to improve pronunciation for the ia voice. I'm not sure how to add it to your project, so I'll just leave it here. ia_list.zip

Since Interlingua shares its sounds with the romance languages, I was wondering what steps would be needed to use existing mbrola voices like Italian.

301 - 320 of 3749