Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

7 New Commits:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
50f58168e100: code cleanup: remove unused *constcharptr and MakeWawe2()

Modified: src/libespeak-ng/synthesize.h
Modified: src/libespeak-ng/translate.h


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
75d66c89d035: code cleanup: Move self_closing checks to ProcessSsmlTag()

This is a bit slower since we don't pass n_xml_buf as an argument but
rather get it with a call to wcslen. It is much cleaner though, since
the name ProcessSsmlTag() implies that all processing should be done
there.

Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/ssml.c
Modified: src/libespeak-ng/ssml.h


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
34657e7ea4fb: code cleanup: move check for SSML comments and declarations to
ProcessSsmlTag()

Note the line in readclause.c:
if ((c2 == '/') || iswalpha(c2) || c2 == '!' || c2 == '?') {

It might be enough to pass everything to ProcessSsmlTag. What are the
cases that are skipped because of this?

Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/ssml.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
959bf26b6b1a: Add a test for XML/SSML character and entity references

Added: tests/ssml/references.expected
Added: tests/ssml/references.ssml2
Modified: tests/ssml.test


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
54d93cf2b4bc: code cleanup: move ssml reference handling logic to a new function ParseSsmlReference()

It's unclear why c2 needs to be set after an entity reference.

Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/ssml.c
Modified: src/libespeak-ng/ssml.h


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
c9dee003bf62: better explanation and nicer formatting for the ssml reference test.

Modified: tests/ssml/references.ssml2


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
5b3da5950aea: Merge pull request #813

Added: tests/ssml/references.expected
Added: tests/ssml/references.ssml2
Modified: src/libespeak-ng/readclause.c
Modified: src/libespeak-ng/ssml.c
Modified: src/libespeak-ng/ssml.h
Modified: src/libespeak-ng/synthesize.h
Modified: src/libespeak-ng/translate.h
Modified: tests/ssml.test


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#813 SSML cleanup

Move SSML related logic from ReadClause to ProcessSsmlTag and to a new function ParseSsmlReference().

Contributes to #369 and should make locating SSML bugs easier.

Join espeak-ng@groups.io to automatically receive all group messages.