Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after

Neither of these versions seem to call PopParamStack or PushParamStack


[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after ""

Neither of these versions seem to call PopParamStack or PushParamStack


[espeak-ng:master] New Comment on Pull Request #808 Fix to #737 (ssml voice change) and Cleanup
By jaacoppi:

My findings after moving the self_closing logic to ProcessSsmlTag():

This check should only catch self-closing tags like
. There are no such tags in the input file of the original bug report, but still the code somehow finds them. I suspect it's a wide char issue

bool self_closing is used for popping the SSML parameter stack

  1. With len = wcslen(xml_buf);, checks are passed and nothing is changed in the behaviour (ie. bug still exists)

  2. With len = strlen(xml_buf);,

  3. checks fail

  4. the voice is not changed midway through the sentence

  5. the voice is not changed back after /voice

Neither of these versions seem to call PopParamStack or PushParamStack

Join espeak-ng@groups.io to automatically receive all group messages.