Updates to Github #github


espeak-ng@groups.io Integration <espeak-ng@...>
 

12 New Commits:

[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
516144d63aa6: code cleanup: combine Wavegen_Klatt() and Wavegen_Klatt2().

Wavegen_Klatt2() only had one if-statement and then called
Wavegen_Klatt(). Wavegen_Klatt() was never called directly.

Modified: src/libespeak-ng/klatt.c
Modified: src/libespeak-ng/klatt.h
Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
1b7c3303ef4f: code cleanup: pass WGEN_DATA wdata as a parameter instead of using a global

Contributes to #68.

Modified: src/libespeak-ng/klatt.c
Modified: src/libespeak-ng/klatt.h
Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
388be80da77e: code cleanup: pass voice_t wvoice as a parameter instead of using a global

SetSynth_Klatt() was using wvoice in two ways:
1) global wvoice was used directly
2) global wvoice was also passed in Wavegen_Klatt() as an argument "v"

Now the code only uses the function argument wvoice

Contributes to #68.

Modified: src/libespeak-ng/klatt.c
Modified: src/libespeak-ng/klatt.h
Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
9232f1911e80: code cleanup: remove unnecessary references to out_start.

Unsigned char *out_start is a global only used in speech.c.

Modified: src/libespeak-ng/klatt.c
Modified: src/libespeak-ng/speech.c
Modified: src/libespeak-ng/synthesize.h
Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
3b4cca483224: code cleanup: combine Wavegen() and Wavegen2().

Wavegen2() only had one if-statement and then called
Wavegen(). Wavegen() was never called directly.

Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
992745508e0c: code cleanup: pass voice_t wvoice as a parameter to Wavegen() instead of using a
global

Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
c0ff3696b950: code cleanup: change global int current_phoneme table to static

It's only used in SpeakNextClause() and related to SelectPhonemeTable().

Another solution void be to keep SelectPhonemeTable() as a void function
and do a current_phoneme_table = voice->phoneme_tab_ix after the call to
SelectPhonemeTable().

Modified: src/libespeak-ng/phoneme.h
Modified: src/libespeak-ng/synthdata.c
Modified: src/libespeak-ng/synthdata.h
Modified: src/libespeak-ng/synthesize.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
65847bd25100: code cleanup: remove phoneme_tab_flags

It is memset and set once, but never checked or used for anything.

Modified: src/libespeak-ng/phoneme.h
Modified: src/libespeak-ng/synthdata.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
713e8a9e2c93: code cleanup: remove unused parameter from SetUpPhonemeTable.

See commit 65847bd251004f0a1d5d1. Bool recursing is not used for
anything anymore. Fixes a (compiler warning.

Modified: src/libespeak-ng/synthdata.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
a4041952c522: code cleanup: remove unused references to f_log

f_log is only used in compiledict.c.

Modified: src/libespeak-ng/synthesize.c
Modified: src/libespeak-ng/wavegen.c


[espeak-ng:master] By Juho Hiltunen <jaacoppi@...>:
5d03047c1955: code cleanup: remove unused int vowel_transition[4]

There's two variables with the same name:
1) in struct PHONEME_DATA, used by *phdata, *phdata_next and *phdata_prev
2) an unnecessary one that's only being memset() twice but never used
for anything

Modified: src/libespeak-ng/synthdata.c
Modified: src/libespeak-ng/synthesize.c
Modified: src/libespeak-ng/synthesize.h


[espeak-ng:master] By Valdis Vitolins <valdis.vitolins@...>:
bddd8a8bde78: Merge pull request #795

Modified: src/libespeak-ng/klatt.c
Modified: src/libespeak-ng/klatt.h
Modified: src/libespeak-ng/phoneme.h
Modified: src/libespeak-ng/speech.c
Modified: src/libespeak-ng/synthdata.c
Modified: src/libespeak-ng/synthdata.h
Modified: src/libespeak-ng/synthesize.c
Modified: src/libespeak-ng/synthesize.h
Modified: src/libespeak-ng/wavegen.c


[espeak-ng/espeak-ng] Pull request closed by valdisvi:

#795 Various code cleanups

Various code cleanups: change globals to function arguments, combine functions and remove unused code.

Most changes are with the voice output (klatt.c, wavegen.c etc). There might not be enough test cases to detect if an error has been made here.


[espeak-ng:master] New Comment on Pull Request #795 Various code cleanups
By valdisvi:

To make it less risky, before that I added additional test for Klatt voice. As all tests passed, I merged it.

Join espeak-ng@groups.io to automatically receive all group messages.